-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port/CategoryTheory.PEmpty #2363
Conversation
mattrobball
commented
Feb 18, 2023
•
edited by github-actions
bot
Loading
edited by github-actions
bot
- depends on: [Merged by Bors] - feat: Port CategoryTheory.DiscreteCategory #2326
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
….DiscreteCategory' into port/CategoryTheory.DiscreteCategory
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
This PR/issue depends on:
|
Unblocked by Note: this file, despite its length, puts serious strain on Lean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please leave a porting note in the file about the strain placed on Lean?
bors d+
Mathlib/CategoryTheory/Pempty.lean
Outdated
universe w v u | ||
|
||
-- morphism levels before object levels. See note [CategoryTheory universes]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
universe w v u | |
-- morphism levels before object levels. See note [CategoryTheory universes]. | |
universe w v u | |
-- morphism levels before object levels. See note [CategoryTheory universes]. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with |
Added a note at the top. Thought I’ve since found a worse one 😧 |
bors r+ |
Co-authored-by: Matthew Ballard <matt@mrb.email> Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded:
|